Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile overview infinite scroll not working #866

Open
BentiGorlich opened this issue Jun 26, 2024 · 1 comment
Open

Profile overview infinite scroll not working #866

BentiGorlich opened this issue Jun 26, 2024 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@BentiGorlich
Copy link
Member

Describe the bug
When you have infinite scroll enabled and go to a profile that has too many posts for one page the infinite scroll will not work when going to the end of the page

On which Mbin instance did you find the bug?
[gehirneimer.de]

Which Mbin version was running on the instance?
[1.6.0 ~ f37b596]

To Reproduce
Steps to reproduce the behavior:

  1. Enable infinite scroll
  2. Go to an active profile
  3. Scroll down to the end of the page
  4. Pagination pops up, but not more results

Expected behavior
It should add the next posts down there

@BentiGorlich BentiGorlich added the bug Something isn't working label Jun 26, 2024
@e-five256
Copy link
Member

e-five256 commented Jun 28, 2024

I have another branch like my search infinite PR #770 one here https://github.com/MbinOrg/mbin/tree/e5/user-infinite which started this work (only on overview page atm)

But I can't seem to figure out on either one why results don't appear. If I look at the AJAX response, the results are right there in between entries, but on the actual page they aren't appearing, it'll be sparse where some are missing, and I haven't been able to figure out why yet

Edit: I think it's clearly comments that aren't showing. This is viewing user1's profile that comments on some admin entries, and the comments aren't shown, only the entry is that they posted on

non-infinite results infinite results
image image

I'm just confused as to how this same template can render comments when not infinite scroll but fails when infinite

Edit: But post comments appear to work with infinite scrolling on tag pages 🤔 and once again the same template

@melroy89 melroy89 added this to the v1.7.3 milestone Sep 12, 2024
@melroy89 melroy89 modified the milestones: v1.7.3, v1.7.4 Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants