Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local subscriber count in magazine info endpoint #1196

Open
ismailkarsli opened this issue Oct 21, 2024 · 2 comments · May be fixed by #1251
Open

Local subscriber count in magazine info endpoint #1196

ismailkarsli opened this issue Oct 21, 2024 · 2 comments · May be fixed by #1251
Assignees
Labels
api API related issues and pull requests enhancement New feature or request
Milestone

Comments

@ismailkarsli
Copy link

Is your feature request related to a problem? Please describe.
I'm trying to add Mbin support to Lemmy Federate and the tool needs the local subscribers count in order to determine if it should sub/unsub.

Describe the solution you'd like
Add a local subscriber count field to the response of the /api/magazine/name/{magazine_name} endpoint.

@ismailkarsli ismailkarsli added the enhancement New feature or request label Oct 21, 2024
@BentiGorlich BentiGorlich added the api API related issues and pull requests label Nov 24, 2024
@BentiGorlich BentiGorlich self-assigned this Nov 24, 2024
@BentiGorlich BentiGorlich added this to the v1.7.4 milestone Nov 24, 2024
@BentiGorlich
Copy link
Member

@melroy89 I would just add property like hasLocalSubscribers instead of publishing the local subscriber counts which are also not available in the web UI.

What are you guys thinking about that?

@jwr1
Copy link
Member

jwr1 commented Nov 24, 2024

Honestly, I think it would be nice to have the actual local subscriber count. Back when that was shown instead of federated subscriber count (I don't remember if that was from Kbin or not), it was nice to be able to see what kinds of magazines were popular on the specific instance. It wouldn't have to be used in the Mbin web UI, but it could at least be used in 3rd party clients.

@BentiGorlich BentiGorlich linked a pull request Nov 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API related issues and pull requests enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants