Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] egress qdisc support #7

Open
robimarko opened this issue Dec 8, 2021 · 7 comments
Open

[Feature Request] egress qdisc support #7

robimarko opened this issue Dec 8, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@robimarko
Copy link

Hi,
Does the driver support use of egress qdiscs?

We are trying to drop all egress traffic and unlike ingress rules, it does not appear to work, we can still see traffic out of the switch ports.

https://github.com/Marvell-switching/Switchdev-prestera/wiki/acl-configuration
Also does not mention egress at all.

Regards,
Robert

@Mickey201
Copy link
Contributor

Hi Robert, that's right, Marvell Switchdev drivers currently support only ingress qdiscs.
Egress ACL support is planned for one of the future releases.

@jmpolom
Copy link

jmpolom commented Dec 8, 2021

@Mickey201 can you please leave this open to track progress? This feature is important to our use case.

Egress ACL support is planned for one of the future releases.

Can you provide any more concrete of a timeline than "future releases"?

cc: @storrgie

@Mickey201 Mickey201 added the enhancement New feature or request label Dec 8, 2021
@Mickey201
Copy link
Contributor

Ok, I'll reopen it and let's implement a practice of adding "[Feature Request]" in the subject field for all similar issues.
For this one - I'll add it.
As for the schedule, we currently reopening the current DENT 3 content list and we will examine also this request.
Currently, no commitment can be set.

@Mickey201 Mickey201 reopened this Dec 8, 2021
@Mickey201 Mickey201 changed the title egress qdisc support [Feature Request] egress qdisc support Dec 8, 2021
@jmpolom
Copy link

jmpolom commented Dec 8, 2021

I'll reopen it and let's implement a practice of adding "[Feature Request]" in the subject field for all similar issues

Good practice. I see you also added a label. Also a good practice.

As for the schedule, we currently reopening the current DENT 3 content list and we will examine also this request.

Is this a Marvell managed DENT 3 content list? Could we discuss this tomorrow during the FWG call and reconcile against the DENT Project proposed feature list we've been working on?

@Mickey201
Copy link
Contributor

Mickey201 commented Dec 8, 2021

Is this a Marvell managed DENT 3 content list? Could we discuss this tomorrow during the FWG call and reconcile against the DENT Project proposed feature list we've been working on?

Sorry but I think It's too early, more information will be shared once a stable draft will be ready.

@jmpolom
Copy link

jmpolom commented Dec 8, 2021

once a stable draft will be ready

Stable draft of this Marvell feature list or the DENT project list? I think we can say the DENT project feature list is stable enough, if that is the issue here. Otherwise, when do you think that this list will be stable enough on the Marvell side for a discussion?

@taraschornyiplv
Copy link
Collaborator

Support for egress has been added in v4 driver
Please consult wiki
https://github.com/Marvell-switching/switchdev-prestera/wiki/ACL#acl-overview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants