-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rubocop TrailingCommaInLiteral issues at UI build #17328
Comments
ManageIQ/guides#303 and #17327 contain a solution for that. |
This issue has been automatically marked as stale because it has not been updated for at least 6 months. If you can still reproduce this issue on the current release or on Thank you for all your contributions! |
We have several PRs related to this issue in various projects. They are listed at ManageIQ/guides#303 (comment). The issue should be kept open. |
We need to update this in conjunction with the bot. We probably need to come up with some better plan at keeping the bot more up to date more frequently. |
Related - ManageIQ/miq_bot#432 |
@saulotoledo @Fryguy is this still an issue after the recent rubocop update? |
Closing due to rubocop update |
At version
0.53.0
, theTrailingCommaInLiteral
rule at Rubocop has been split intoTrailingCommaInHashLiteral
andTrailingCommaInArrayLiteral
and no longer exists. The current version definition for Rubocop allow us to use the version0.52.1
or superior, but it is not possible to have both versions by having that options in yourrubocop.yml
file.Thus, we have to choose between using a version lower than
0.53.0
or using a superior version and update our rules.This problem can be seen at https://github.com/ManageIQ/manageiq-ui-classic/ project, that uses the Gemfile in the core project in its build process.
The text was updated successfully, but these errors were encountered: