Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubocop TrailingCommaInLiteral issues at UI build #17328

Closed
saulotoledo opened this issue Apr 22, 2018 · 7 comments
Closed

Rubocop TrailingCommaInLiteral issues at UI build #17328

saulotoledo opened this issue Apr 22, 2018 · 7 comments

Comments

@saulotoledo
Copy link
Member

saulotoledo commented Apr 22, 2018

At version0.53.0, the TrailingCommaInLiteral rule at Rubocop has been split intoTrailingCommaInHashLiteral and TrailingCommaInArrayLiteral and no longer exists. The current version definition for Rubocop allow us to use the version 0.52.1 or superior, but it is not possible to have both versions by having that options in your rubocop.yml file.

Thus, we have to choose between using a version lower than 0.53.0 or using a superior version and update our rules.

This problem can be seen at https://github.com/ManageIQ/manageiq-ui-classic/ project, that uses the Gemfile in the core project in its build process.

@saulotoledo
Copy link
Member Author

saulotoledo commented Apr 22, 2018

ManageIQ/guides#303 and #17327 contain a solution for that.

@miq-bot
Copy link
Member

miq-bot commented Oct 29, 2018

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@miq-bot miq-bot added the stale label Oct 29, 2018
@saulotoledo
Copy link
Member Author

saulotoledo commented Nov 7, 2018

We have several PRs related to this issue in various projects. They are listed at ManageIQ/guides#303 (comment). The issue should be kept open.

@Fryguy Fryguy added pinned and removed stale labels Dec 18, 2018
@Fryguy
Copy link
Member

Fryguy commented Dec 18, 2018

We need to update this in conjunction with the bot. We probably need to come up with some better plan at keeping the bot more up to date more frequently.

@Fryguy
Copy link
Member

Fryguy commented Dec 18, 2018

Related - ManageIQ/miq_bot#432

@djberg96
Copy link
Contributor

djberg96 commented Aug 6, 2019

@saulotoledo @Fryguy is this still an issue after the recent rubocop update?

@gtanzillo
Copy link
Member

Closing due to rubocop update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants