Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.4.3 change in number of ASCII characters supported for casting to double #1638

Closed
jtwhite79 opened this issue Feb 20, 2024 · 2 comments · Fixed by #2067
Closed

6.4.3 change in number of ASCII characters supported for casting to double #1638

jtwhite79 opened this issue Feb 20, 2024 · 2 comments · Fixed by #2067
Labels

Comments

@jtwhite79
Copy link

Describe the bug
It seems that with version 6.4.3, the number of characters used to represent a double in ASCII input files has been decreased. Previously we could use ridiculously long string representations of double value like

"70.0000000000000000000000000000000000000000000000000"
(which can happen using pest++ and wanting to use long parameter names as pest++ needs to fill the space between markers in a template file numeric digits)

with 6.4.3 we are now getting some CI errors:

2024-02-19T08:40:08.7321283Z ERROR REPORT:
2024-02-19T08:40:08.7321430Z
2024-02-19T08:40:08.7321558Z 1. File unit 1042: Error converting
2024-02-19T08:40:08.7322010Z "70.0000000000000000000000000000000000000000000000000" to a real number
2024-02-19T08:40:08.7322471Z in following line:
2024-02-19T08:40:08.7322848Z 2. 1 40 6 36.5 70.0000000000000000000000000000000000000000000000000

we have a work-around for the tests but users who want long, descriptive parameter names might also run into this. I realize that number of digits is well beyond the significand of a double...

To reproduce
make a ridiculously long ASCII representation of a double

Expected behavior
MODFLOW-6 might tolerate this ridiculousness as before

@jtwhite79 jtwhite79 added the bug label Feb 20, 2024
@jdhughes-usgs
Copy link
Contributor

@jtwhite79 can you provide a small test model that reproduces the error?

@jtwhite79
Copy link
Author

Thanks @jdhughes-usgs!
for_joe.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants