Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Can't add Galaxy Clusters to Events if Tag Editor permission is not granted #975

Open
vincenzocaputo opened this issue Apr 23, 2023 · 4 comments

Comments

@vincenzocaputo
Copy link
Contributor

vincenzocaputo commented Apr 23, 2023

It seems that adding a galaxy cluster to an event is not possible if these conditions are met:

  • The Connector Tag associated with the galaxy does not exist
  • The user does not have the Tag Editor permission

The PyMISP method tag(misp_entity, tag, local=False) returns the following message error:

ERROR:pymisp:Something went wrong (403): {'saved': False, 'name': 'Could not attachTagToObject Tag', 'message': 'Could not attachTagToObject Tag', 'url': '/tags/attachTagToObject', 'errors': 'Failed to attach 1 tags. Reasons: {"0":"Tag not found and insufficient privileges to create it."}'}

However, the same user can attach the Galaxy Cluster to the Event via GUI, triggering the connector tag creation.

@SunsetR
Copy link

SunsetR commented Apr 1, 2024

Hello, I encountered the same issue when updating events. Events can only be updated successfully when there are tag labels associated with the galaxy. Do you have any new solutions for this?🫡

@Rafiot
Copy link
Member

Rafiot commented Apr 1, 2024

This is odd it works via the GUI, not being to create tag when the user doesn't have the Tag Editor perms is working as it should be.

Any idea @mokaddem @iglocska @righel ?

@vincenzocaputo
Copy link
Contributor Author

This is odd it works via the GUI, not being to create tag when the user doesn't have the Tag Editor perms is working as it should be.

Any idea @mokaddem @iglocska @righel ?

Yes, it works as it should but as far as I know at the moment the most convenient (and recommended) way to add a galaxy cluster to an event is to use connector tags (see also your response here.

Maybe the add_galaxy function should be used in these cases?

@iglocska
Copy link
Member

iglocska commented Apr 2, 2024

This is odd it works via the GUI, not being to create tag when the user doesn't have the Tag Editor perms is working as it should be.

Sounds like there (correctly) is an exception for that case in place, however, it also sounds like it's not adhered to everywhere. Definitely one to fix on MISP side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants