Why do you set a default logging handler?

[jloehel]

PyMISP/pymisp/__init__.py

Lines 6 to 13 in aee6945

	FORMAT = "%(levelname)s [%(filename)s:%(lineno)s - %(funcName)s() ] %(message)s"
	formatter = logging.Formatter(FORMAT)
	default_handler = logging.StreamHandler()
	default_handler.setFormatter(formatter)
	logger = logging.getLogger(__name__)
	logger.addHandler(default_handler)
	logger.setLevel(logging.WARNING)

It's some kind of confusing if I configure logging on CLI level. Python does not recommend to use any handler other than a NullHandler for libraries. Is there any special reason for it?

[Rafiot]

I don't remember the reason, but it was 3 years ago. I guess we can remove it.

[Rafiot]

And the handler is gone: 00ba313

[chrisinmtown]

Good that you removed the handler. Less good that you removed the call to setLevel.

[jloehel]

@chrisinmtown Why is the missing logger.setLevel(logging.WARNING) a issue? You can set the level easily when you setup a handler with:

In [1]: import logging

In [2]: logger = logging.getLogger("pymisp")

In [3]: logger.addHandler(logging.StreamHandler())

In [4]: logger.setLevel(logging.DEBUG)

In [5]: import pymisp
-c:1: DeprecationWarning: 
As our baseline system is the latest Ubuntu LTS, and Ubuntu LTS 20.04 has Python 3.8 available,
we will officially deprecate python versions below 3.8 on January 1st 2022.
**Please update your codebase.**
pymisp loaded properly

@Rafiot Maybe it's good to add a NullHandler. Something like that to pymisp/__init__.py:

# Set default logging handler to avoid "No handler found" warnings.
import logging
from logging import NullHandler

logging.getLogger(__name__).addHandler(NullHandler())

[Rafiot]

I will add the null handler, yes.