-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update model description to include pointers to suitable images in IDC #68
Comments
I was thinking about two sections here @fedorov.
|
How about we start with |
Oh yes, absolutely. I should've said Is it possible to download a dicom series by their |
Yes, download does not require BigQuery. For that we would need to include How about we include the following attributes:
|
Looks good @fedorov :) Do you have any example around somewhere of how to ..
|
Sure! IDC version is in the name of the dataset of the table, e.g.,
Download is with
I can write this up if you point me to the docs page dedicated to contribution process. |
So, if I select a patient via the IDC portal, I get the following s5cmd command: I see no notion of the IDC-Version nor SeriesInstanceUID, is It seems to me that the easiest way to automatically download a specific instance then would be to specify that resource uuid. We can mention the IDC version and SeriesInstanceUID alongside to provide the right context, or is there a method to derive the resource uid based on the information without running a big-query (assuming such a big query would require authorization). |
It is a unique resource uuid. But just knowing uuid you cannot get the bucket URL without querying anything, so we would definitely need the URLs. Otherwise we would need to run a query. Unless the data is retracted (e.g., if there is a PHI breach, or scientific misconduct), the file corresponding to this UUID should remain available.
Yes, the information may be redundant (you can get the file from the bucket URL alone), but if the file moves (which is rare, but may happen), you would be able to query to hopefully find the new location. And SeriesInstanceUID is going to be in the DICOM file, while crdc_series_uuid is not a DICOM attribute. Note that you can now query basic metadata fields without login and without BigQuery - see https://github.com/ImagingDataCommons/idc-index. Note that right now crdc_series_uuid is not one of the columns included in idc-index. We will revise this after IDC data release v17. |
That's awesome! So once |
At least right now, idc-index handles only the latest version of IDC. We need to think and discuss if and how we would want to support prior versions. I still think all of the 4 attributes I suggested would be good to have in the model metadata. |
As discussed earlier, I think this should be added to
model.json
and also propagate into the web page of the model. I suggest the most straightforward would be to include SeriesInstanceUID(s) for the suitable DICOM series that were confirmed to produce acceptable results with the model.The text was updated successfully, but these errors were encountered: