Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update interface with type 'string' for compartment_id #120

Open
sbordeynemics opened this issue Aug 18, 2021 · 1 comment
Open

Update interface with type 'string' for compartment_id #120

sbordeynemics opened this issue Aug 18, 2021 · 1 comment

Comments

@sbordeynemics
Copy link
Contributor

plugins-nodejs-sdk/src/mediarithmics/api/reference/UserIdentifierInterface.ts

Line 31 in dc79ba8

compartment_id?: number; //To Be changed to `string` when the back will be updated

This line is commented 'update to type string when back is updated', which is the case, as far as I know.
pljarlegan added a commit to pljarlegan/plugins-nodejs-sdk that referenced this issue Aug 18, 2021
@pljarlegan
Fix issue MEDIARITHMICS#120
a4615e4
@ghost
Copy link

ghost commented Aug 19, 2021

@sbordeyne : before merging the PR we'll have to check that the mediarithmics backend as been updated. And I'm not sure. Maybe think with product team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sbordeynemics