Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor waterorientation to standard API #38

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

robinzyb
Copy link

Refactor: #18

To be done: #24

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@pep8speaks
Copy link

pep8speaks commented Jun 29, 2024

Hello @robinzyb! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 46:80: E501 line too long (114 > 79 characters)
Line 54:80: E501 line too long (103 > 79 characters)
Line 83:80: E501 line too long (82 > 79 characters)

Line 64:80: E501 line too long (106 > 79 characters)
Line 66:80: E501 line too long (95 > 79 characters)
Line 67:80: E501 line too long (101 > 79 characters)
Line 77:80: E501 line too long (111 > 79 characters)
Line 78:80: E501 line too long (102 > 79 characters)
Line 79:80: E501 line too long (119 > 79 characters)
Line 84:80: E501 line too long (108 > 79 characters)
Line 87:80: E501 line too long (115 > 79 characters)
Line 94:80: E501 line too long (89 > 79 characters)
Line 103:80: E501 line too long (84 > 79 characters)
Line 119:80: E501 line too long (99 > 79 characters)
Line 203:80: E501 line too long (107 > 79 characters)
Line 266:80: E501 line too long (99 > 79 characters)
Line 734:80: E501 line too long (84 > 79 characters)
Line 735:80: E501 line too long (86 > 79 characters)
Line 736:80: E501 line too long (90 > 79 characters)
Line 882:80: E501 line too long (90 > 79 characters)

Comment last updated at 2024-06-29 22:14:36 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants