Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra_flags in boards.txt prevents user adding flags? #264

Open
dmcomm opened this issue Aug 14, 2023 · 1 comment
Open

extra_flags in boards.txt prevents user adding flags? #264

dmcomm opened this issue Aug 14, 2023 · 1 comment

Comments

@dmcomm
Copy link

dmcomm commented Aug 14, 2023

If I understand correctly, the normal way for the user to add flags is via compiler.cpp.extra_flags etc. But build.extra_flags overrides this so it doesn't do anything. And overriding build.extra_flags is not an option either because this would delete the values that MiniCore is using.

Edit: Sorry, I'm confused, they do seem to be separate things. But boards.txt does also set compiler.cpp.extra_flags in some cases.

@dmcomm dmcomm changed the title build.extra_flags in boards.txt prevents user adding flags? extra_flags in boards.txt prevents user adding flags? Aug 14, 2023
@dmcomm
Copy link
Author

dmcomm commented Aug 14, 2023

OK, it seems that setting compiler.cpp.extra_flags in platform.local.txt does nothing in MiniCore because it's set in boards.txt. Setting it via --build-property does apply, but this presumably overrides the values in boards.txt. And this doesn't conflict provided that LTO is disabled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant