Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing components (collection for redesign of architecture) #86

Open
sr258 opened this issue Sep 1, 2019 · 4 comments
Open

Missing components (collection for redesign of architecture) #86

sr258 opened this issue Sep 1, 2019 · 4 comments
Assignees
Labels
H5P-Editor research Research into how the php implementation does things

Comments

@sr258
Copy link
Member

sr258 commented Sep 1, 2019

I've looked through the code of the PHP implementation (editor and regular library) and identified these components / this functionality that we haven't put into our implementation yet:

  • logging & statistics generation: e.g. use of libraries by author, view of embedded content etc. (see h5p-php-library:h5p-event-base.class.php for a list of events)
  • store user state (for continuing later)
  • full validation of content against library semantics

A few (less important things maybe) that we haven't done yet:

  • turn hub on - off (config)
  • presave.js files (see h5p-editor-php-library:h5peditor.class.php->hasPresave(...) and ->addPresaveFile(...)
  • prefixing css files (not sure why this is done; see: h5p-editor-php-library:h5peditor.class.php->buildCssPath(...)
  • cached assets (aggregate all css and js files into two big files to decrease http requests; done in h5p-php-library:h5p-default-storage.class.php->cacheAssets(...); looks very much like what Webpack does, maybe we can use a library like this for this)
  • library devolopment functionality
  • siteTypes: local, network, internet (local = localhost; network = internal network); auto-detected in h5p-php-library:h5p.classes.php->detectSiteType()
  • check if server can run with the configuration (on startup) (e.g.: are the directories writeable, sanity check if config values)
@sr258 sr258 added the research Research into how the php implementation does things label Sep 1, 2019
@JPSchellenberg
Copy link
Member

Wow. Thank you for your research. It is nice to have some kind of todo list. How do we want to handle such a todo list? Create an issue for every todo?

@sr258
Copy link
Member Author

sr258 commented Sep 2, 2019

Having one issue for each item would flood the issue tracker and make it hard to see what's urgent and not. How about putting a component list with status on the wiki once @rtens has though about the 2nd architectural design?

@JPSchellenberg
Copy link
Member

You are right. A wiki page seems good.

@sr258
Copy link
Member Author

sr258 commented Sep 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
H5P-Editor research Research into how the php implementation does things
Projects
None yet
Development

No branches or pull requests

3 participants