Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mass content upgrade #590

Open
sr258 opened this issue Jun 8, 2020 · 1 comment
Open

Mass content upgrade #590

sr258 opened this issue Jun 8, 2020 · 1 comment
Labels
[type] feature Changes that introduce a new feature (resulting in minor-version-bump)

Comments

@sr258
Copy link
Member

sr258 commented Jun 8, 2020

The PHP implementation have a feature that allows updating all content of a certain version of a contain type to another. It is part of the library management functionality.

The library updates are fully run on the client side (browser) in the PHP implementation in the core file h5p-content-upgrade.js. It is done that way as upgrades are done in JavaScript. They pass a H5PAdminIntegrationObject with a property libraryInfo to the update page, which dynamically creates the UI in JavaScript. Execution of updates in run in the browser.

Maybe it is possible to offload this work to the server as NodeJS executes JavaScript after all!
@sr258 sr258 added the [type] feature Changes that introduce a new feature (resulting in minor-version-bump) label Jun 8, 2020
@sr258 sr258 mentioned this issue Jun 8, 2020
Merged
@sr258
Copy link
Member Author

sr258 commented Nov 20, 2020

It might be an option to use https://github.com/patriksimek/vm2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[type] feature Changes that introduce a new feature (resulting in minor-version-bump)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sr258