Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency between parameter raising from LayeredOpticalSystem and LayeredDetector #262

Open
LouisDesdoigts opened this issue Nov 3, 2023 · 0 comments
Open

Inconsistency between parameter raising from LayeredOpticalSystem and LayeredDetector #262

LouisDesdoigts opened this issue Nov 3, 2023 · 0 comments
Assignees
@LouisDesdoigts
Labels
enhancement New feature or request low-priority Low-priority issue that isn't likely to adressed soon

Comments

@LouisDesdoigts
Copy link
Owner

The optical systems raise the leaves of the individual layers, whereas the detectors only raise the layer key.

Simple fix, add this to LayeredDetector.__getattr__

        for layer in list(self.layers.values()):
            if hasattr(layer, key):
                return getattr(layer, key)
@LouisDesdoigts LouisDesdoigts added enhancement New feature or request low-priority Low-priority issue that isn't likely to adressed soon labels Nov 3, 2023
@LouisDesdoigts LouisDesdoigts self-assigned this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LouisDesdoigts LouisDesdoigts

Labels
enhancement New feature or request low-priority Low-priority issue that isn't likely to adressed soon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LouisDesdoigts