Block::getTemplate() fails on innerBlock

[dsturm]

Since #209 Block::getTemplate() returns a JSON / string. Hence the map() callback in

acf-composer/src/Block.php

Lines 339 to 341 in a497082

	$innerBlocks = collect($value['innerBlocks'])->map(function ($innerBlock) {
	return $this->getTemplate($innerBlock)->all();
	})->collapse();

will fail at calling ->all() on a string.

I'm currently not sure, whether we need the ->all() in the callback.

[Log1x]

Yeah I think the method will have to be split or the logic changed slightly. In the current form, that map needs to be returning as an array.

[Log1x]

Re-reading 209 again, I'm slightly confused by the initial issue. $template doesn't get cached. Is this happening from partials?

[dsturm]

Unfortunately, I had not tested the issue mentioned by @djaevlen. As a quickfix, if I ditch the ->all() in the callback, it works. But I'm not sure, whether all possible template data of a block would convert correctly.

[Log1x]

i should have a fix in a few minutes

[djaevlen]

Re-reading 209 again, I'm slightly confused by the initial issue. $template doesn't get cached. Is this happening from partials?

In my issue the block (acf/button) that mainly have the template issue is using a addPartial.

/**
     * The block field group.
     *
     * @return array
     */
    public function fields()
    {
        $button = Builder::make('button');

        $button->addPartial(ButtonPartial::class);

        return $button->build();
    }

[Log1x]

The block (acf/button) that mainly have the issue is using a addPartial.

let me know if this still happens on .10