Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASR] Add duration variable type (+ maybe more) #694

Open
apple1417 opened this issue Jun 24, 2023 · 1 comment
Open

[ASR] Add duration variable type (+ maybe more) #694

apple1417 opened this issue Jun 24, 2023 · 1 comment
Labels
auto splitting This is about the auto splitting implementation. enhancement An improvement for livesplit-core. feature A new user visible feature for livesplit-core.

Comments

@apple1417
Copy link

Currently, variables can only be set to strings. This means all scripts each need to pull in some string formatting library if they want to use another type. While this isn't really a massive problem, it would be nice if some more types were exposed, so livesplit could handle it all in one place.

The one type in particular which could benefit greatly is durations. There's currently no way for a script to know the main timer format (nor do I think there should be), so if a script does it's own formatting it might look very different. Livesplit also already has a lot of timer formatting settings which could be reused.

If we're going to add a new variable type for durations, it might be worth also adding ones for [u]ints, doubles, and bools too, to flesh out all the primitives.

@CryZe
Copy link
Collaborator

CryZe commented Jun 24, 2023

Yeah this was always the plan. When I added variables I wanted to have an MVP implementation first and then later extend it.

@CryZe CryZe added enhancement An improvement for livesplit-core. feature A new user visible feature for livesplit-core. auto splitting This is about the auto splitting implementation. labels Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto splitting This is about the auto splitting implementation. enhancement An improvement for livesplit-core. feature A new user visible feature for livesplit-core.
Projects
None yet
Development

No branches or pull requests

2 participants