Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organization.name should not be required #422

Open
cragun47 opened this issue Jan 25, 2022 · 1 comment
Open

Organization.name should not be required #422

cragun47 opened this issue Jan 25, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@cragun47
Copy link
Contributor

cragun47 commented Jan 25, 2022 •
edited
Loading

HL7 FHIR Organization does not require Name. The current converter does.

See Organization.yml name_v1 has required: true

name_v1:
   type: STRING
   condition: $idValue NULL
   valueOf: CWE.2 | XON.1 | $orgName
   required: true
   expressionType: HL7Spec
   vars:
      idValue: CWE.1 | XON.10 | XON.3 
name_v2:
   type: STRING
   condition: $idValue NOT_NULL
   valueOf: CWE.2 | XON.1
   expressionType: HL7Spec
   vars:
      idValue: CWE.1 | XON.10 | XON.3

This incorrect dependency should be removed, or at least carefully documented as to why we require it.
When this is fixed, remove payor_2: orgName: String, IN2.25.1 in Organization.yml.

Testing to see if it could be removed caused the following tests to fail:

HL7ADTMessageTest > testAdtA03MinimumPlusInsuranceGroup() FAILED               java.lang.AssertionError at HL7ADTMessageTest.java:336

Hl7DFTMessageTest > testResourceCreationFromDFT() FAILED
    java.lang.AssertionError at Hl7DFTMessageTest.java:73

HL7ADTMessageTest > testAdtA03AllSegmentsAndMultipleGroups() FAILED
    org.opentest4j.AssertionFailedError at HL7ADTMessageTest.java:208

ResourceExpressionTest > test_organization_creation_with_missing_id_and_name_value() FAILED
    org.opentest4j.AssertionFailedError at ResourceExpressionTest.java:362

Hl7FinancialInsuranceTest > [1] DFT^P03^DFT_P03 FAILED
    java.lang.AssertionError at Hl7FinancialInsuranceTest.java:342

Hl7FinancialInsuranceTest > [2] ADT^A01^ADT_A01 FAILED
    java.lang.AssertionError at Hl7FinancialInsuranceTest.java:342

Hl7FinancialInsuranceTest > testBasicInsuranceCoverageFields() FAILED
    java.lang.AssertionError at Hl7FinancialInsuranceTest.java:129

Hl7FinancialInsuranceTest > testFailingOrganizationTelecom() FAILED
    java.lang.AssertionError at Hl7FinancialInsuranceTest.java:587

Hl7FinancialInsuranceTest > testInsuranceCoverageOfSelfAndTenant() FAILED
    java.lang.AssertionError at Hl7FinancialInsuranceTest.java:512

Hl7FinancialInsuranceTest > testInsuranceCoverageFromIN2() FAILED
    java.lang.AssertionError at Hl7FinancialInsuranceTest.java:664

Hl7FinancialInsuranceTest > testInsuranceCoverageFromIN2Self() FAILED
    java.lang.AssertionError at Hl7FinancialInsuranceTest.java:755
@cragun47 cragun47 added the bug Something isn't working label Jan 25, 2022
@cragun47
Copy link
Contributor Author

cragun47 commented Mar 4, 2022

Under current testing, removing required true causes these failures:

ResourceExpressionTest > test_organization_creation_with_missing_id_and_name_value() FAILED
    org.opentest4j.AssertionFailedError at ResourceExpressionTest.java:362

Hl7ORMMessageTest > testORMO01PatientWithVisitWithSingleInsuranceWithMultipleAllergyAndOrder() FAILED
    java.lang.AssertionError at Hl7ORMMessageTest.java:159

HL7ADTMessageTest > testAdtA03MinimumPlusInsuranceGroup() FAILED
    java.lang.AssertionError at HL7ADTMessageTest.java:355

Hl7DFTMessageTest > testResourceCreationFromDFT() FAILED
    java.lang.AssertionError at Hl7DFTMessageTest.java:77

Hl7ORMMessageTest > testORMO01PatientWithMultipleInsuranceAndMultipleOrdersWithAndWithoutOBXtypeTX() FAILED
    java.lang.AssertionError at Hl7ORMMessageTest.java:268

HL7ADTMessageTest > testAdtA05MinimumWithNoProceduresAndMultipleInsurance(String) > io.github.linuxforhealth.hl7.message.HL7ADTMessageTest.testAdtA05MinimumWithNoProceduresAndMultipleInsurance(String)[1] FAILED
    java.lang.AssertionError at HL7ADTMessageTest.java:457

Hl7OMPMessageTest > testOMPO09PatientWithPatientVisitAndMultipleInsuranceAndMinimumOrderGroups() FAILED
    java.lang.AssertionError at Hl7OMPMessageTest.java:85

Hl7ORMMessageTest > testORMO01PatientWithVisitWithInsuranceAndOrder() FAILED
    java.lang.AssertionError at Hl7ORMMessageTest.java:109

Hl7OMPMessageTest > testOMPO09FullPatientWithPatientVisitAndInsuranceAndMinimumOrderGroups() FAILED
    java.lang.AssertionError at Hl7OMPMessageTest.java:130

HL7ADTMessageTest > testAdtA05MinimumWithNoProceduresAndMultipleInsurance(String) > io.github.linuxforhealth.hl7.message.HL7ADTMessageTest.testAdtA05MinimumWithNoProceduresAndMultipleInsurance(String)[2] FAILED
    java.lang.AssertionError at HL7ADTMessageTest.java:457

HL7ADTMessageTest > testAdtA03AllSegmentsAndMultipleGroups() FAILED
    java.lang.AssertionError at HL7ADTMessageTest.java:224

Hl7RDEMessageTest > testRdePatientWithEncounterWithInsuranceAndOrderWithObservation(String) > io.github.linuxforhealth.hl7.message.Hl7RDEMessageTest.testRdePatientWithEncounterWithInsuranceAndOrderWithObservation(String)[1] FAILED
    java.lang.AssertionError at Hl7RDEMessageTest.java:222

Hl7RDEMessageTest > testRdePatientWithEncounterWithInsuranceAndOrderWithObservation(String) > io.github.linuxforhealth.hl7.message.Hl7RDEMessageTest.testRdePatientWithEncounterWithInsuranceAndOrderWithObservation(String)[2] FAILED
    java.lang.AssertionError at Hl7RDEMessageTest.java:222

Hl7RDEMessageTest > testRdePatientWithFullPatientVisitWithFullInsuranceAndMinimumOrder(String) > io.github.linuxforhealth.hl7.message.Hl7RDEMessageTest.testRdePatientWithFullPatientVisitWithFullInsuranceAndMinimumOrder(String)[1] FAILED
    java.lang.AssertionError at Hl7RDEMessageTest.java:125

Hl7RDEMessageTest > testRdePatientWithFullPatientVisitWithFullInsuranceAndMinimumOrder(String) > io.github.linuxforhealth.hl7.message.Hl7RDEMessageTest.testRdePatientWithFullPatientVisitWithFullInsuranceAndMinimumOrder(String)[2] FAILED
    java.lang.AssertionError at Hl7RDEMessageTest.java:125

Hl7RDEMessageTest > testRdePatientWithEncounterWithMultipleInsuranceWithAllergyAndOrderWithObservation(String) > io.github.linuxforhealth.hl7.message.Hl7RDEMessageTest.testRdePatientWithEncounterWithMultipleInsuranceWithAllergyAndOrderWithObservation(String)[1] FAILED
    java.lang.AssertionError at Hl7RDEMessageTest.java:268

Hl7RDEMessageTest > testRdePatientWithEncounterWithMultipleInsuranceWithAllergyAndOrderWithObservation(String) > io.github.linuxforhealth.hl7.message.Hl7RDEMessageTest.testRdePatientWithEncounterWithMultipleInsuranceWithAllergyAndOrderWithObservation(String)[2] FAILED
    java.lang.AssertionError at Hl7RDEMessageTest.java:268

Hl7VXUMessageTest > test_VXU_with_full_patient_group_and_insurance() FAILED
    java.lang.AssertionError at Hl7VXUMessageTest.java:94

Hl7VXUMessageTest > test_VXU_with_minimum_patient_group_plus_coverage_plus_order_group_with_OBX_with_observations() FAILED
    java.lang.AssertionError at Hl7VXUMessageTest.java:207

Hl7FinancialInsuranceTest > testInsuranceCoverageByRelatedFields(String) > io.github.linuxforhealth.hl7.segments.Hl7FinancialInsuranceTest.testInsuranceCoverageByRelatedFields(String)[1] FAILED
    java.lang.AssertionError at Hl7FinancialInsuranceTest.java:419

Hl7FinancialInsuranceTest > testInsuranceCoverageByRelatedFields(String) > io.github.linuxforhealth.hl7.segments.Hl7FinancialInsuranceTest.testInsuranceCoverageByRelatedFields(String)[2] FAILED
    java.lang.AssertionError at Hl7FinancialInsuranceTest.java:419

Hl7FinancialInsuranceTest > testInsuranceCoverageByRelatedFields(String) > io.github.linuxforhealth.hl7.segments.Hl7FinancialInsuranceTest.testInsuranceCoverageByRelatedFields(String)[3] FAILED
    java.lang.AssertionError at Hl7FinancialInsuranceTest.java:419

HL7ADTMessageTest > testAdtA05WithAllergiesMultipleProceduresAndSingleInsurance(String) > io.github.linuxforhealth.hl7.message.HL7ADTMessageTest.testAdtA05WithAllergiesMultipleProceduresAndSingleInsurance(String)[1] FAILED
    java.lang.AssertionError at HL7ADTMessageTest.java:394

Hl7FinancialInsuranceTest > testInsuranceCoverageByRelatedFields(String) > io.github.linuxforhealth.hl7.segments.Hl7FinancialInsuranceTest.testInsuranceCoverageByRelatedFields(String)[4] FAILED
    java.lang.AssertionError at Hl7FinancialInsuranceTest.java:419

HL7ADTMessageTest > testAdtA05WithAllergiesMultipleProceduresAndSingleInsurance(String) > io.github.linuxforhealth.hl7.message.HL7ADTMessageTest.testAdtA05WithAllergiesMultipleProceduresAndSingleInsurance(String)[2] FAILED
    java.lang.AssertionError at HL7ADTMessageTest.java:394

Hl7FinancialInsuranceTest > testInsuranceCoverageByRelatedFields(String) > io.github.linuxforhealth.hl7.segments.Hl7FinancialInsuranceTest.testInsuranceCoverageByRelatedFields(String)[5] FAILED
    java.lang.AssertionError at Hl7FinancialInsuranceTest.java:419

HL7ADTMessageTest > testAdtA01FullPlusMultipleProcedureGroupAndSingleInsurance(String) > io.github.linuxforhealth.hl7.message.HL7ADTMessageTest.testAdtA01FullPlusMultipleProcedureGroupAndSingleInsurance(String)[1] FAILED
    java.lang.AssertionError at HL7ADTMessageTest.java:169

Hl7FinancialInsuranceTest > testInsuranceCoverageByRelatedFields(String) > io.github.linuxforhealth.hl7.segments.Hl7FinancialInsuranceTest.testInsuranceCoverageByRelatedFields(String)[6] FAILED
    java.lang.AssertionError at Hl7FinancialInsuranceTest.java:419

HL7ADTMessageTest > testAdtA01FullPlusMultipleProcedureGroupAndSingleInsurance(String) > io.github.linuxforhealth.hl7.message.HL7ADTMessageTest.testAdtA01FullPlusMultipleProcedureGroupAndSingleInsurance(String)[2] FAILED
    java.lang.AssertionError at HL7ADTMessageTest.java:169

Hl7FinancialInsuranceTest > testInsuranceCoverageByRelatedFields(String) > io.github.linuxforhealth.hl7.segments.Hl7FinancialInsuranceTest.testInsuranceCoverageByRelatedFields(String)[7] FAILED
    java.lang.AssertionError at Hl7FinancialInsuranceTest.java:419

HL7ADTMessageTest > testAdtA01FullPlusMultipleProcedureGroupAndSingleInsurance(String) > io.github.linuxforhealth.hl7.message.HL7ADTMessageTest.testAdtA01FullPlusMultipleProcedureGroupAndSingleInsurance(String)[3] FAILED
    java.lang.AssertionError at HL7ADTMessageTest.java:169

Hl7FinancialInsuranceTest > testInsuranceCoverageByRelatedFields(String) > io.github.linuxforhealth.hl7.segments.Hl7FinancialInsuranceTest.testInsuranceCoverageByRelatedFields(String)[8] FAILED
    java.lang.AssertionError at Hl7FinancialInsuranceTest.java:419

Hl7FinancialInsuranceTest > testInsuranceCoverageUnknownRelationship() FAILED
    java.lang.AssertionError at Hl7FinancialInsuranceTest.java:1067

Hl7FinancialInsuranceTest > testFailingOrganizationTelecom() FAILED
    java.lang.AssertionError at Hl7FinancialInsuranceTest.java:736

Hl7FinancialInsuranceTest > testInsuranceCoverageFromIN2() FAILED
    java.lang.AssertionError at Hl7FinancialInsuranceTest.java:815

Hl7FinancialInsuranceTest > testInsuranceCoverageOfWorkersComp() FAILED
    java.lang.AssertionError at Hl7FinancialInsuranceTest.java:988

Hl7FinancialInsuranceTest > testInsuranceCoverageFromIN2Self() FAILED
    java.lang.AssertionError at Hl7FinancialInsuranceTest.java:907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cragun47