Add the S3 icon

[Francois-lenne]

Add New Icon(s)

Icon Details

Icon ID	Icon
S3

Notes

• add the S3 icon the data lake of AWS

Checklist

• Added icon(s) to the appropriate directory
• Updated documentation with the new icon(s)
• Verified the icon(s) display correctly
• If the icon has light and dark, verified the auto switch works correctly

[Francois-lenne]

@LelouchFR Hi Baptiste, the readme file don't need to be updated anymore ?

[Francois-lenne]

Hi @Daynlight can you provide me a guideline in order to resolve this issue ?

[Daynlight]

Hi @Daynlight can you provide me a guideline in order to resolve this issue ?

It looks good for me icon added, documention updated. You can see your icon in list on your fork branch

[Francois-lenne]

Hi @Daynlight can you provide me a guideline in order to resolve this issue ?

It looks good for me icon added, documention updated. You can see your icon in list on your fork branch

@Daynlight Okay nice ! Don't hesitate to reach me if there a problem with this icons or you want some improvements

[Daynlight]

Hi @Daynlight can you provide me a guideline in order to resolve this issue ?

It looks good for me icon added, documention updated. You can see your icon in list on your fork branch

@Daynlight Okay nice ! Don't hesitate to reach me if there a problem with this icons or you want some improvements

I think you need to cahnge S to s and auto generate readme you need use .github/readme-format.sh

[Francois-lenne]

@Daynlight i have a problem i'm on mac and the command in order to generate the readme don't work

/.github/readme-format.sh
ls: --ignore=-dark.svg: No such file or directory
ls: --ignore=-light.svg: No such file or directory
ls: --ignore=-dark.svg: No such file or directory
ls: --ignore=-light.svg: No such file or directory

[LelouchFR]

@Daynlight i have a problem i'm on mac and the command in order to generate the readme don't work

/.github/readme-format.sh

ls: --ignore=*-dark.svg: No such file or directory

ls: --ignore=*-light.svg: No such file or directory

ls: --ignore=*-dark.svg: No such file or directory

ls: --ignore=*-light.svg: No such file or directory

Can you send the pwd ?

[Francois-lenne]

@Daynlight i have a problem i'm on mac and the command in order to generate the readme don't work
/.github/readme-format.sh
ls: --ignore=-dark.svg: No such file or directory
ls: --ignore=-light.svg: No such file or directory
ls: --ignore=-dark.svg: No such file or directory
ls: --ignore=-light.svg: No such file or directory

Can you send the pwd ?

yes no problem

/Users/francoislenne/skill-icons

[Francois-lenne]

@LelouchFR insted of using

you can use ls | grep -vE '(-dark|-light).svg$'

it's more agnostic to the os or use grep if the os is mac

in order to retrieve the OS do os=$(uname)

and if it's a mac this value is equal to darwin the sub-system of macos

[Daynlight]

@Daynlight i have a problem i'm on mac and the command in order to generate the readme don't work

/.github/readme-format.sh ls: --ignore=-dark.svg: No such file or directory ls: --ignore=-light.svg: No such file or directory ls: --ignore=-dark.svg: No such file or directory ls: --ignore=-light.svg: No such file or directory

I didn't use mac sorry :<

[Daynlight]

@Daynlight i have a problem i'm on mac and the command in order to generate the readme don't work
/.github/readme-format.sh ls: --ignore=-dark.svg: No such file or directory ls: --ignore=-light.svg: No such file or directory ls: --ignore=-dark.svg: No such file or directory ls: --ignore=-light.svg: No such file or directory

I didn't use mac sorry :<

README.md
I generated It for you.
You need only change S3 to s3

[Francois-lenne]

@Daynlight it wiil be ok right now

[Francois-lenne]

oh no i speak too fast @Daynlight

[LelouchFR]

could you just also make the #S3 to #s3 thanks, then it would be all set I guess. (just don't forget to merge main branch to be up to date and regenerate the readme for that (I'm sorry that it has be done on your side right now, but this should be the next problem fixed asap, becasue the script should be ran on pull_request to generate it, so I'm not gonna be doing one for every os or something like that)

[LelouchFR]

lgtm