Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: signature verification failed on BnB Beacon Chain #6336

Closed
j75689 opened this issue Feb 29, 2024 · 1 comment
Closed

[Bug]: signature verification failed on BnB Beacon Chain #6336

j75689 opened this issue Feb 29, 2024 · 1 comment
Labels
bug Something isn't working libraries Impacts the Libraries triage In need of triage

Comments

@j75689
Copy link

j75689 commented Feb 29, 2024

Impacted Library name

@ledgerhq/app-binance

Impacted Library version

1.1.7

Describe the bug

  1. Sign a tx with bnbcli/tbnbcli, and broadcast to the chain.
./bin/tbnbcli send --amount 10000001:BNB --to tbnb1v4wm6hexfkxgv7gu2va6adn2qg7udz3l73g9cc --from ld0 --chain-id Binance-Chain-Ganges --node https://data-seed-pre-0-s1.bnbchain.org:443 --ledger --trust-node --memo "abc"
  1. return signature verification failed
image
  1. But try cmd with different text in --memo (e.g. "123"), that will succeed.
image

Expected behavior

Attempting any of the --memo fields should succeed and no signature verification errors should occur.

Additional context

This problem never occurred when trying to send transactions without using ledger hardware for signing (using the local key of bnbcli/tbnbcli).

There may be inconsistencies in the encoding conversion on the ledger app (not 100% sure)

@j75689 j75689 added bug Something isn't working libraries Impacts the Libraries triage In need of triage labels Feb 29, 2024
@j75689
Copy link
Author

j75689 commented Mar 4, 2024

resolved: bnb-chain/bnc-cosmos-sdk#390

@j75689 j75689 closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libraries Impacts the Libraries triage In need of triage
Projects
None yet
Development

No branches or pull requests

1 participant