-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the RST docs #378
Update the RST docs #378
Conversation
Make a working exanmple to test installation in the examples sub-directory and add a section to the installation instruction about how to test the install.
Add new sections for the config system and using using imSim. Re-title some sections and re-order them in the overall TOC.
The end of the image section doc strings.
Complete config section.
Also remove accidentally committed file.
It fills me with rage I had to do this.
There are a few missing sections, but they are noted.
Put guidance and ideas in for: data-formats.rst lsst-camera.rst lsst-optical.rst module-use.rst including adding an image of the camera focal plane.
Ugh. Chris, I'm still reviewing this! |
Ugh. Sorry! I didn't actually know you were doing a review. Please leave comments here and I will apply them in a new branch since this is already merged (I guess that is the best way). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Chris. I have some comments and corrections. I tried to make inline suggested changes when I thought they were straightforward. If you're happy with them, you can accept them on Github (preferably grouping many of them in a batch commit probably). Places where I had a less specific change are just normal comments.
Oh well. It seems like you won't be able to apply the commits directly, since the PR is closed. That will make this a bit more annoying for you... :( |
Thank you! I'm just super glad it didn't wipe out what you had already started typing. |
Thanks Mike! Because this PR is already merged and such a mess I couldn't just accept things, I did it all manually (sorry for the email barrage). I will actually check in these changes into a new PR. |
Upates to the documentation.