Fix GitHub Actions #112
Merged
Fix GitHub Actions #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok. This now is working but I had to comment out the cache and specify the coverage output. The latter means that coveralls sees a 94% coverage instead of 99%. Not sure what the difference is but I wouldn't spend more time investigating it, at the moment. We can open an issue if needed. |
Closed
damonge
approved these changes
Nov 13, 2024
| @@ -481,6 +481,7 @@ def get_fields_dict(self, tracer_names, cache=None, masks=None, **kwargs): | |||
| # We add the spin to make sure we distinguish fields of | |||
| # different types even though they share the same mask | |||
| k = mask_names[i] + str(spins[i]) | |||
| print(nmt_conf) | |||
| @@ -319,7 +319,7 @@ def get_covariance_block( | |||
| mn[2], | |||
| mn[3], | |||
| mn[4], | |||
| lmax=int(ell[-1]), | |||
| # lmax=int(ell[-1]), # Not available in NaMaster v2 | |||
|
Thanks. Addressed. I will merge when the tests pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve #110.
At the moment, I have updated TJPCov to use NaMaster v2. There is a remaining error with the binning implementation that was implemented recently.