Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GQ7: Don't publish 0,0 position #365

Open
Aposhian opened this issue Nov 7, 2024 · 0 comments
Open

GQ7: Don't publish 0,0 position #365

Aposhian opened this issue Nov 7, 2024 · 0 comments
Labels
enhancement New feature or request New This issue is new, and should not be marked as stale

Comments

@Aposhian
Copy link

Aposhian commented Nov 7, 2024

Is your feature request related to a problem? Please describe.
When the device first initializes, it starts publishing its location at 0,0 latitude longitude.

Describe the solution you'd like
Don't publish to ekf/llh_position if the filter is not initialized. It could still be appropriate to publish to odometry topics even if position doesn't exist yet, since those contain velocities and orientations as well.

This may be a feature to gate behind a parameter flag.

Describe alternatives you've considered
A downstream filter (in client application code) to filter out null positions from any calculations.

Additional context
While filter state and uncertainty are good measures to gate operation on, it would be nice to gate the actual data stream itself, because then it doesn't mess up tools that may not necessarily care about validation in general, but for which these outliers make life more difficult: i.e. analytics, visualizations, etc.

@Aposhian Aposhian added the enhancement New feature or request label Nov 7, 2024
@github-actions github-actions bot added the New This issue is new, and should not be marked as stale label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request New This issue is new, and should not be marked as stale
Projects
None yet
Development

No branches or pull requests

1 participant