Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fortran test does not validate correctness #179

Open
lindstro opened this issue Sep 7, 2022 · 0 comments
Open

Fortran test does not validate correctness #179

lindstro opened this issue Sep 7, 2022 · 0 comments

Comments

@lindstro
Copy link
Member

lindstro commented Sep 7, 2022

As identified in #163, the lone Fortran test does not actually ensure that the data is correctly compressed or decompressed. It also has other shortcomings:

  • The array being compressed is composed of 32-bit integers, but zFORp_stream_set_rate() is called with zFORp_type_float.
  • In spite of the small range and number of integers, the test will never losslessly compress the array, regardless of the rate set. This is because the integers are not properly normalized (shifted).
  • Even if validation were performed, no return code is provided to the OS to indicate whether the test passed. Given the difficulties of portably returning an exit code from Fortran, ctest's PASS_REGULAR_EXPRESSION may be preferable.
  • The source file extension should be .f90.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant