Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hierarchy op "getLength" is not global #137

Open
jeanlucf22 opened this issue Jul 13, 2020 · 0 comments
Open

Hierarchy op "getLength" is not global #137

jeanlucf22 opened this issue Jul 13, 2020 · 0 comments

Comments

@jeanlucf22
Copy link
Contributor

In classes like HierarchyCellDataOpsReal, operations are typically global, with a call to some MPI reduce function at the end when necessary.
The exception seems to be:

template
int64_t HierarchyCellDataOpsReal::getLength(
const int data_id,
const bool interior_only) const

where no sum across MPI tasks is done. I am guessing that this function was introduced to support Sundials5.0. If this is the main purpose, then it would be another reason to have a sum across MPI tasks since Sundials needs a global vector length.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant