Update for new BIP340: XOnly is always even #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLFourn
force-pushed
the
xonly_is_even
branch
from
dbaa0e6
to
8ed6fbf
Compare
BIP340 recently changed to transform 32-byte xonly to even y public keys consistently. I see no reason to keep the SquareY option as its not used in Bitcoin anymore.
- Implement encode and decode as explicit functions - Move all hex stuff into the module
- Use new csv test file - Use new hex module from secp25kfun
Abandoned the old one (mention by real-or-random) to the one suggested here: sipa/bips#207 (comment)
LLFourn
force-pushed
the
xonly_is_even
branch
from
8ed6fbf
to
0e45abc
Compare
This was referenced Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to latest BIP340 that will now presumably be final. I completely removed the logic for
SquareY. I think that there are systems like Grin that still use old BIP340 type signatures but I don't think it's worth keeping it in here for them at the moment.In addition:
hexmodule for hex encoding/decoding since I needed it in tests and the logic was already mostly done in serialization code.