Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connected component label periodic boundary conditions #786

Open
burlen opened this issue Nov 6, 2023 · 0 comments
Open

connected component label periodic boundary conditions #786

burlen opened this issue Nov 6, 2023 · 0 comments
Labels
1_high_priority an issue that should be fixed prior to the next release bug

Comments

@burlen
Copy link
Collaborator

burlen commented Nov 6, 2023

the cuda implementation needs to check the periodic bc conditions across cuda domain decomp. step 2 of the bard test can identify the issue if periodic bc is enabled. parameter table row 43 and 115 trigger the issue.

smic:~/work/teca/teca/bin-mpich$diff -u bard_test_step_2_cpu_out.txt ../mpich-bin-cpu/bard_test_step_2_gpu_out.txt 
--- bard_test_step_2_cpu_out.txt	2023-11-06 07:10:02.962644986 -0800
+++ ../mpich-bin-cpu/bard_test_step_2_gpu_out.txt	2023-11-06 07:05:15.192203178 -0800
@@ -41,7 +41,7 @@
 row_id=40  periodic_in_x=1  num_comps=4
 row_id=41  periodic_in_x=1  num_comps=9
 row_id=42  periodic_in_x=1  num_comps=7
-row_id=43  periodic_in_x=1  num_comps=7
+row_id=43  periodic_in_x=1  num_comps=8
 row_id=44  periodic_in_x=1  num_comps=4
 row_id=45  periodic_in_x=1  num_comps=7
 row_id=46  periodic_in_x=1  num_comps=3
@@ -113,7 +113,7 @@
 row_id=112  periodic_in_x=1  num_comps=3
 row_id=113  periodic_in_x=1  num_comps=9
 row_id=114  periodic_in_x=1  num_comps=4
-row_id=115  periodic_in_x=1  num_comps=9
+row_id=115  periodic_in_x=1  num_comps=10
 row_id=116  periodic_in_x=1  num_comps=11
 row_id=117  periodic_in_x=1  num_comps=3
 row_id=118  periodic_in_x=1  num_comps=5

bard_test_step_2_gpu_out.txt
bard_test_step_2_cpu_out.txt

@burlen burlen added 2_medium_priority an issue that should be fixed, but is not critical to the next release bug 1_high_priority an issue that should be fixed prior to the next release and removed 2_medium_priority an issue that should be fixed, but is not critical to the next release labels Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1_high_priority an issue that should be fixed prior to the next release bug
Projects
None yet
Development

No branches or pull requests

1 participant