Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation issue on Macs with arm architecture #761

Open
dchandan opened this issue Jun 16, 2023 · 1 comment
Open

Compilation issue on Macs with arm architecture #761

dchandan opened this issue Jun 16, 2023 · 1 comment
Labels
1_high_priority an issue that should be fixed prior to the next release feature

Comments

@dchandan
Copy link

Code lines 27--31 in the cpuid function in teca_thread_util.cxx do not compile on Macs with Apple Silicon (ARM architecture). This causes the installation of the python package to fail. Any suggestions how these lines can be modified?

@burlen burlen added feature 1_high_priority an issue that should be fixed prior to the next release labels Jun 16, 2023
@burlen
Copy link
Collaborator

burlen commented Jun 16, 2023

Thanks for the report, we have not tested teca on m1 yet. I don't have one available at the moment but #762 should get you going, or comment out those lines.

We'll need to dig a little deeper into this to get threading working correctly on m1. it seems as though Apple wraps cpuid and we should be able to get what we need from that. here are some links to more info.

https://opensource.apple.com/source/xnu/xnu-4570.61.1/osfmk/arm/cpuid.h.auto.html
https://opensource.apple.com/source/WTF/WTF-7601.1.46.42/wtf/Platform.h.auto.html
https://developer.apple.com/documentation/apple-silicon/addressing-architectural-differences-in-your-macos-code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1_high_priority an issue that should be fixed prior to the next release feature
Projects
None yet
Development

No branches or pull requests

2 participants