Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use udunits to check units #749

Open
burlen opened this issue Mar 23, 2023 · 0 comments
Open

use udunits to check units #749

burlen opened this issue Mar 23, 2023 · 0 comments

Comments

@burlen
Copy link
Collaborator

burlen commented Mar 23, 2023

in a number of algorithms the units of scalar fields or coordinates are crucial. the netcdf files typically provide units for all data. we've been checking this manually using string comparison, and we don't handle many valid unit formats. udunits can decode these and has comparison methods. some places where we make such checks:

  1. integrated vapor transport
  2. integrated water vapor
  3. TC MPI
  4. normalize coordinates

this is likely an incomplete list, and other algorithms should probably have checks. grep for '.get("units"', '[ *"units" *]', etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant