Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added persistence options for etcd #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danielstankw
Copy link

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

KusionStack/karpor#347

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

values.yaml
etcd.yaml

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@elliotxx
Copy link
Collaborator

@danielstankw Your actions are so fast, let me test it first 👍

@elliotxx
Copy link
Collaborator

elliotxx commented Jul 31, 2024

@danielstankw Hi, I used default parameters for installation, but I seem to have encountered an problem:

image

@danielstankw
Copy link
Author

@elliotxx have you specified the storageClassName?

@elliotxx
Copy link
Collaborator

@elliotxx have you specified the storageClassName?

@danielstankw I don’t specify storageClassName, but I understand it should work normally. In fact, I am doing a regression test.

@elliotxx
Copy link
Collaborator

elliotxx commented Aug 7, 2024

@danielstankw Hi, I haven't seen any progress on this PR recently. Do you need me to provide more information?

@elliotxx
Copy link
Collaborator

@danielstankw Hi, PR #50 provides basic and compatible support for persistence. Can you continue to optimize on this basis?

@danielstankw
Copy link
Author

Hi @elliotxx
My sincere apologies for lack of reply.
I am currently overloaded with some tasks, would love to return to the project when I find time but for now if you want to get it done sooner, I suggest someone takes over.

@elliotxx
Copy link
Collaborator

elliotxx commented Aug 22, 2024

@danielstankw Bro, I'm sorry to disturb you. Of course, you should first focus on your work. I understand very well. I'm just not sure if I provided enough information that caused you to get stuck somewhere. If it's convenient for you, please feel free to come back anytime! We think your feedback and contribution are very important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants