Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add topologyspreadconstraints for service #100

Merged
merged 6 commits into from
Nov 21, 2024

Conversation

gshilei
Copy link
Contributor

@gshilei gshilei commented Nov 20, 2024

What type of PR is this?

What this PR does / why we need it:

PR for issue KusionStack/kusion#1303
Please help to have a review. Thanks.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@Yangyang96
Copy link

The comments are clear and straightforward, and the code is properly formatted! Thank you for your contribution! @gshilei

Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gshilei gshilei force-pushed the add-topologyspreadconstraints branch from 4723437 to b205227 Compare November 21, 2024 08:05
@liu-hm19 liu-hm19 merged commit e849dcf into KusionStack:main Nov 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants