Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Painter API failed to parse scientific notation numbers, which cause client crashes #917

Open
xXStrayXx opened this issue Oct 23, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@xXStrayXx
Copy link

xXStrayXx commented Oct 23, 2024

Minecraft Version

1.20.1

KubeJS Version

2001.6.5-build.14

Rhino Version

2001.2.3-build.6

Architectury Version

9.2.14

Forge/Fabric Version

Forge 47.3.0

Describe your issue

When the number in javascript is small (or big) enough, the formation gave to painter is processed into scientific notation number shaped as N.NNNe+NN (n refer to number)
In this context, the ratio (refering to the ratio of health and max health) could be in scientific notation state when the 'boss' have health low enough but not dead.
But the painter api process the N.NNNe+NN as (N.NNNe) (identifier) + (plus) NN (int). And when painter api found that N.NNNe is not defined (of course it isn't) it raises a client 'java.lang.IllegalStateException' which causes the client to crash instantly.
This could cause some weird border situation giltches that are hard to prevent or fix in javascript.

Crash report/logs

crash-2024-10-23_12.12.26-client.txt
boss.js.txt

@xXStrayXx xXStrayXx added the bug Something isn't working label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant