Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on kotlin-reflect #142

Open
ArtificialPB opened this issue Jul 5, 2024 · 0 comments
Open

Remove dependency on kotlin-reflect #142

ArtificialPB opened this issue Jul 5, 2024 · 0 comments
Labels
type: chore Involves routine, non-critical, or housekeeping work, contributing to project maintenance.

Comments

@ArtificialPB
Copy link
Member

Module

Other

📝 Description

kotlin-reflect is transitively included via jackson-module-kotlin dependency, which is used only in a few cases. Removing this dependency will lower the size of our jars by ~3mb. The only two modules that need / can include the reflect library are ethers-abigen and ethers-abigen-plugin.

  • Remove jackson-module-kotlin dependency from jackson gradle bundle
  • Implement custom deserializer for RpcError class
  • Use JsonProperty annotation on most other classes that will break
  • Deprecate AbiType.Tuple.struct(KClass, varargs AbiType) function, add and replace it with struct(Class, StructFactory, varargs AbiType) in abigen contracts. Will need to explicitly define dependency on kotlin-reflect for now and remove it when deprecated functions are removed.
@ArtificialPB ArtificialPB added the type: chore Involves routine, non-critical, or housekeeping work, contributing to project maintenance. label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Involves routine, non-critical, or housekeeping work, contributing to project maintenance.
Projects
None yet
Development

No branches or pull requests

1 participant