Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out $suspendImpl functions declared in interfaces #270

Open
fzhinkin opened this issue Oct 10, 2024 · 1 comment · Fixed by #271
Open

Filter out $suspendImpl functions declared in interfaces #270

fzhinkin opened this issue Oct 10, 2024 · 1 comment · Fixed by #271
Labels
enhancement New feature or request jvm

Comments

@fzhinkin
Copy link
Collaborator

On JVM, the compiler generates special <original function name>$suspendImpl methods for every open suspendable function. For classes, these methods are package private and are never included in dump. For interfaces, however, such functions could only be either private (but we need to call them outside the interface, so that doesn't work), or public (we are here now). So, these public functions do not constitute the public ABI and are public only due to restrictions imposed on class files.

BCV should filter these methods out of generated dumps.
@fzhinkin fzhinkin added enhancement New feature or request jvm labels Oct 10, 2024
@fzhinkin fzhinkin mentioned this issue Oct 10, 2024
Open
@fzhinkin
Copy link
Collaborator Author

See Kotlin/kotlinx.coroutines#4244 for example of a dump with $suspendImpl functions.

fzhinkin added a commit that referenced this issue Oct 10, 2024
@fzhinkin
Filter out $suspendImpl methods.
b696830 
Closes #270
fzhinkin added a commit that referenced this issue Oct 10, 2024
@fzhinkin
Filter out $suspendImpl methods.
a2c493c 
Closes #270
@fzhinkin fzhinkin mentioned this issue Oct 10, 2024
Merged
@fzhinkin fzhinkin linked a pull request Oct 10, 2024 that will close this issue
Filter out $suspendImpl functions from dumps #271
Merged
fzhinkin added a commit that referenced this issue Oct 18, 2024
@fzhinkin
Filter out $suspendImpl functions from dumps (#271)
91dc2a9 
* Enable default interface methods generation
* Filter out $suspendImpl methods.

Closes #270
shanshin pushed a commit to JetBrains/kotlin that referenced this issue Oct 28, 2024
@fzhinkin @shanshin
[ABI Validation] Filter out $suspendImpl functions from dumps
d68b796 
* Enable default interface methods generation
* Filter out $suspendImpl methods.

Closes Kotlin/binary-compatibility-validator#270
Pull request Kotlin/binary-compatibility-validator#271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request jvm
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Filter out $suspendImpl functions from dumps Kotlin/binary-compatibility-validator
1 participant
@fzhinkin