fix: remove event listeners when component is destroyed

[arturovt]

We should manually remove event listeners to prevent memory leaks.

[KillerCodeMonkey]

But since the listeners are bind to native Dom elements they should be destroyed, when the Dom element gets destroyed. So I guess there is no memory leak?

[arturovt]

No, they're not automatically removed when DOM nodes are removed. They're marked as dangling references preventing the DOM from being garbage collected too.

[KillerCodeMonkey]

But there should not any references to the dom node itself and then the listeners gets removed automatically, as far as i know.

and since the parent of those nodes are removed the listeners should removed as well.

PS: i just want to understand where the memory should come from. I am glad you are caring a lot about this library :)

[KillerCodeMonkey]

okay i know a little how garbage collection works, but in a short way:

since we are not knowing what a programmer is doing with quill and its instance we can not be sure, that the eventlistener gets remove when the domnode is removed, because the node could persist in memory as well.

So this is a memory leak that can occur but is per se not a memory leak directly occurring when using ngx-quill, because there are those 3 event listeners, right?

So it is more a safety handling that this will not lead to a memory leak issue, right?

[arturovt]

No, this is a leak directly caused by ngx-quill.

[KillerCodeMonkey]

strange... i do not get it in my head, because then quilljs or someone else need to hold some references on the editor instance?

because if the component gets destroyed there are no outer references until it is stored somewhere where it is used?

[arturovt]

---

[KillerCodeMonkey]

@arturovt thanks :). seems like using this.quillEditor inside the callback is enough to create the dep-cycle. so even if the editor instance is removed it stays in memory, because the handler is referencing the it. And so the instance itselfs stays there.

now i got it.