Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test non-finite values with Float32List entrypoints #3687

Open
lexaknyazev opened this issue Aug 23, 2024 · 2 comments
Open

Test non-finite values with Float32List entrypoints #3687

lexaknyazev opened this issue Aug 23, 2024 · 2 comments
Assignees

Comments

@lexaknyazev
Copy link
Member

Chromium fails on the following call; Firefox and WebKit do not.

// Uncaught TypeError: Failed to execute 'uniform1fv' on 'WebGLRenderingContext':
// The provided float value is non-finite.
gl.uniform1fv(location, [NaN]); 

Relevant WebIDL entries:

typedef unrestricted float GLfloat;
typedef ([AllowShared] Float32Array or sequence<GLfloat>) Float32List;
undefined uniform1fv(WebGLUniformLocation? location, Float32List v);

@kenrussell FYI

@kenrussell
Copy link
Member

Thanks for finding this. Could you please file a crbug with a tiny test case (if an exception's produced, test fails, otherwise test passes) and point me to it? Blink's IDL team will need to look at this.

@kenrussell
Copy link
Member

Thanks again @lexaknyazev for finding this and filing crbug.com/361823993 . It turned out this was a regression with major impact. It's very important that tests be added which pass arrays including non-finite float values to various WebGL API entry points.

@kenrussell kenrussell self-assigned this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants