Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finds bobber, but immediately clicks #18

Open
Azlynne opened this issue Mar 16, 2019 · 7 comments
Open

finds bobber, but immediately clicks #18

Azlynne opened this issue Mar 16, 2019 · 7 comments
Assignees
Labels

Comments

@Azlynne
Copy link

Azlynne commented Mar 16, 2019

I've finally been able to get the cursor to find the bobber, but it immediately clicks instead of waiting for a fish. It then reports on the console that a fish was caught successfully. I've turned down the water graphics, and had the splash sensitivity set to the whole spectrum with no effect. I've also tried using different bobber toys to see if that made any difference, but it doesn't. Am I missing something?

@KevinTyrrell
Copy link
Owner

Hello @Azlynne

This usually happens when calibration failed, but reported success anyways. Can you do what you did in the past to calibrate the program, then screenshot after FishingBot moves the cursor? In other words:

  1. Walk up to the water, zoom into first person, aim view at horizon
  2. Type /cast Fishing or click on the fishing ability, fishing begins.
  3. Click the calibrate button on FishingBot
  4. Back in World of Warcraft, hover over the fishing bobber so that the "[Fishing Bobber]" tooltip appears.
  5. If successful, FishingBot will move your cursor to where it thinks the [Fishing Bobber] tooltip is. Take a screenshot at that moment and post it here.

@Azlynne
Copy link
Author

Azlynne commented Mar 17, 2019

bobber
Sorry about the crappy phone photo, the cursor wasn't showing up in the screenshot for some reason.

@KevinTyrrell
Copy link
Owner

@Azlynne Thank you. Interesting, so calibration seems to have worked perfectly. Okay..

Can you make sure the 'DEBUG' button is illuminated and then begin reading/copying some of the output? FishingBot will look at the colors of the screen near the bobber and give it a number of how much 'blue' (water color) there is in that area. When the amount of blue changes to a certain amount, it will click. Let me know:

  • On average, what value is it typically printing right before/right when clicking?
  • What is the required threshold when the slider is dragged to the very left or very right?

@Azlynne
Copy link
Author

Azlynne commented Mar 20, 2019

Sorry for the late response. I haven't been able to play the last few days.

Scan Speed: 75
Splash: ~30
8:35:43 AM: Fishing will now begin. Please avoid using your mouse/keyboard.
8:35:50 AM: [DEBUG] Scanned Value: 7.33, Value Needed: 6.50
8:35:50 AM: Fish caught successfully.
8:36:00 AM: [DEBUG] Scanned Value: 6.55, Value Needed: 6.50
8:36:00 AM: Fish caught successfully.
8:36:07 AM: [DEBUG] Scanned Value: 8.30, Value Needed: 6.50
8:36:07 AM: Fish caught successfully.
8:36:13 AM: [DEBUG] Scanned Value: 8.19, Value Needed: 6.50
8:36:13 AM: Fish caught successfully.
8:36:22 AM: [DEBUG] Scanned Value: 5.54, Value Needed: 6.50
8:36:22 AM: [DEBUG] Scanned Value: 9.63, Value Needed: 6.50
8:36:22 AM: Fish caught successfully.

Scan: 75
Splash: 0
8:40:20 AM: [DEBUG] Scanned Value: 8.68, Value Needed: 10.00
8:40:21 AM: [DEBUG] Scanned Value: 11.87, Value Needed: 10.00
8:40:21 AM: Fish caught successfully.
8:40:28 AM: [DEBUG] Scanned Value: 10.19, Value Needed: 10.00
8:40:28 AM: Fish caught successfully.
8:40:38 AM: [DEBUG] Scanned Value: 7.55, Value Needed: 10.00
8:40:38 AM: [DEBUG] Scanned Value: 10.75, Value Needed: 10.00
8:40:38 AM: Fish caught successfully.

Scan: 75
Splash: 100
8:41:48 AM: [DEBUG] Scanned Value: 6.66, Value Needed: 0.00
8:41:48 AM: Fish caught successfully.
8:41:58 AM: [DEBUG] Scanned Value: 8.19, Value Needed: 0.00
8:41:58 AM: Fish caught successfully.
8:42:05 AM: [DEBUG] Scanned Value: 7.31, Value Needed: 0.00
8:42:05 AM: Fish caught successfully.
8:42:13 AM: [DEBUG] Scanned Value: 7.54, Value Needed: 0.00
8:42:13 AM: Fish caught successfully.

@KevinTyrrell
Copy link
Owner

Thank you so much for doing that testing. This data illustrates to me that there is a flaw in the sensitivity slider.

Essentially, when I wrote this addon for Patch 1.12.1 World of Warcraft, I didn't account for the advanced water graphics of retail. The new graphics are much more dynamic and FishingBot needs to be very sensitive to be able to detect splashes. I've heard however that people who play on BFA, Legion, etc are able to get the program to work. However it may just be that with your graphics, your area in-game, etc the program just isn't able to detect the correct changes in color (so it can know when the bobber splashed).

This will require overhauling of the algorithm I use to detect splashes. In the future when I come back to address this project, I will make sure to have this fixed. In the meantime unfortunately the program may not meet your standards for which I apologize. I can assure you though that it works perfectly on older versions of the game (for which it was designed for).

Thank you for your help.

@KevinTyrrell KevinTyrrell self-assigned this Mar 23, 2019
@Kylepetrucci
Copy link

Curious if you are able to define "in the future" and have an estimate on the algorithm overhaul. I still have a few mounts that I need to fish for and would love to utilize this program to do so. It worked great for fishing in the yellow-greenish lava in Argus for the Legion mount, but fails to ever detect splashes on all graphical water quality settings in regular BfA water.

@KevinTyrrell
Copy link
Owner

Curious if you are able to define "in the future" and have an estimate on the algorithm overhaul. I still have a few mounts that I need to fish for and would love to utilize this program to do so. It worked great for fishing in the yellow-greenish lava in Argus for the Legion mount, but fails to ever detect splashes on all graphical water quality settings in regular BfA water.

Unfortunately I don't have any time frame on when this may be completed. The program was designed for earlier versions of World of Warcraft and performs well there, but on retail clients it is a challenge. The best thing I believe you could do is play around with the graphics settings in your video options. I believe 'spell effects' is the one with the 'Splash' so that should be turned high, while the water graphics should be turned as low as possible.

I'll notify you here in this thread when a new version is released that addresses/may address this issue.

Thank you for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants