Test : Domain모듈 Reader/Store 테스트코드 보완 #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GBGreenBravo
changed the title
oxix97
approved these changes
Mar 25, 2024
Comment on lines
+71
to
+75
| afterEvaluate { | ||
| classDirectories.setFrom(files(classDirectories.files.collect { | ||
| fileTree(dir: it, exclude: ['**/global/config/**', '**/*Request.class', '**/*Response.class', '**/*Message.class', '**/*Controller.class', '**/OruryClientApplication.class']) | ||
| })) | ||
| } |
There was a problem hiding this comment.
민협님 대신 답변을 드리자면, jacoco 관련 설정입니다
저희가 작성하지 않는 테스트코드들(~Controller, ~config, ~response) 들을 jacoco가 전부 체크하다보니, 전반적인 커버리지가 떨어지고 파악하기가 원활하지 않아 해당 내용 추가했습니다.
There was a problem hiding this comment.
JaCoCo로 정확한 테스트 커버리지 확인하기 위해, 테스트 대상이 아닌 파일 제외해주는 설정입니다!
kkkapuq
approved these changes
Mar 25, 2024
Comment on lines
+71
to
+75
| afterEvaluate { | ||
| classDirectories.setFrom(files(classDirectories.files.collect { | ||
| fileTree(dir: it, exclude: ['**/global/config/**', '**/*Request.class', '**/*Response.class', '**/*Message.class', '**/*Controller.class', '**/OruryClientApplication.class']) | ||
| })) | ||
| } |
There was a problem hiding this comment.
민협님 대신 답변을 드리자면, jacoco 관련 설정입니다
저희가 작성하지 않는 테스트코드들(~Controller, ~config, ~response) 들을 jacoco가 전부 체크하다보니, 전반적인 커버리지가 떨어지고 파악하기가 원활하지 않아 해당 내용 추가했습니다.
… into test/#402_TestCodes_for_Crew_Domain
… into test/#402_TestCodes_for_Crew_Domain
c0olcode
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
closed #402
PR 유형
어떤 변경 사항이 있나요?
PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.