Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: On Linux, The prompts in Connect-Keeper echo the input if the input is longer than the terminal's width #123

Open
bror-lauritz opened this issue Jun 30, 2024 · 2 comments

Comments

@bror-lauritz
Copy link

When using Connect-Keeper in PowerShell on Linux: if your input is longer than the length of the terminal, the line is echoed back per character you enter (see image).

The main problem is when it asks for the SSO Token, which is 576 (?) characters. Pasting it in will cause a lot of echoing, which locks the terminal for a 5-10 seconds while it processes the output.

image

Screencast.from.2024-06-30.18-19-58.mp4

Specs

OS: RHEL 7 and Fedora 40
Terminal: Gnome terminal, Kitty, Putty and the terminal in Visual Studio Code
Powershell version: 7.3.12 and 7.4.3
PowerCommander: 0.9.10 and 0.9.11

This is not a problem on Windows, as far as I can tell.

@sk-keeper
Copy link
Collaborator

sk-keeper commented Jul 1, 2024

This issue was reported long time.
PowerShell/PowerShell#11636

The PowerCommander will use [Console]::ReadLine or PSReadLine module if it is installed.

@bror-lauritz
Copy link
Author

PSReadLine is installed by default in the PowerShell Core version of Powershell.

I'm not sure what you mean that PowerCommander uses PSReadLine to read the input, as PSReadLine doesn't have any functions that mimic "Read-Host". PSReadLine is designed to provide shell-like editing on the CLI, and MS hasn't implemented a way to use it to read input.

Well, it does have one, but it adds everything it reads into the shell history, which doesn't seem very secure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants