You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I can't see any reason why required_spec_claims couldn't be a HashSet<&'static str>, or, even better, use an enum instead.
Using a String as the value type leads to unnecessary allocations as well as assigning to that field being rather unergonomic. Having to convert your &'static strs to owned strings is annoying and wasteful.
Current workaround is to just not use the feature.
The text was updated successfully, but these errors were encountered:
I don't remember why it's that way but Validation has been like that for >7 years.
In practice I think most users create a Validation struct once in their program and re-use it (the original intended use) so allocations are not an issue in that case
I can't see any reason why
required_spec_claims
couldn't be aHashSet<&'static str>
, or, even better, use an enum instead.Using a
String
as the value type leads to unnecessary allocations as well as assigning to that field being rather unergonomic. Having to convert your&'static str
s to owned strings is annoying and wasteful.Current workaround is to just not use the feature.
The text was updated successfully, but these errors were encountered: