-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SequentFormula class #3478
Draft
unp1
wants to merge
17
commits into
KeYProject:main
Choose a base branch
from
Drodt:removeSequentFormula
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unp1
force-pushed
the
removeSequentFormula
branch
2 times, most recently
from
June 13, 2024 08:09
19f4f15
to
9debf5e
Compare
The class is a left-over from previous times when a formula in the sequent could have a constraint attached. This commit works towards generalizing proof structures
unp1
force-pushed
the
removeSequentFormula
branch
2 times, most recently
from
June 13, 2024 09:06
2e72f76
to
16f0da5
Compare
unp1
force-pushed
the
removeSequentFormula
branch
from
June 13, 2024 09:08
16f0da5
to
5f71f24
Compare
unp1
added
the
RFC
"Request for comments" is the appeal for making and expressing your opinion on a topic.
label
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended Change
This PR prepares the ground for generalizing proof and calculus structures.
It removes the superfluous SequentFormula class, which is only a behaviorless
container for a term. The class is a left-over from times when we had formulas with
constraints on the sequent level
It depends on PR #3472 to be merged first as it is based on that branch
Plan
Type of pull request
Ensuring quality
The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.