[FIX] 키워드 조회 API 로직 수정 #103
Conversation
| public void deleteTask(Long taskId) { | ||
| Task findTask = taskRepository.findByIdOrThrow(taskId); | ||
|
|
||
| findTask.deleted(); | ||
| findTask.getSubTasks().forEach(this::deleteSubTaskAndCard); | ||
| } |
There was a problem hiding this comment.
p3;
@Transactional이 빠져있는 것 같습니다!
| taskRepository.save(Task.builder() | ||
| .name(requestDto.getName()) | ||
| .category(findCategory) | ||
| .isDeleted(false) |
There was a problem hiding this comment.
p4;
false는 Service에서 값으로 넣는 것 보다 entity 생성자에 들어가는 것이 조금 더 좋을 것 같네요!
| private final SubTaskRepository subTaskRepository; | ||
|
|
||
| @Override | ||
| @Transactional |
There was a problem hiding this comment.
p2;
readOnly = true option을 넣어주세요!
| @Column(name = "is_deleted", nullable = false) | ||
| private boolean isDeleted; | ||
| private Boolean isDeleted; |
There was a problem hiding this comment.
p4;
Wrapper class로 바꾼 이유가 궁금합니다! 기본적으로 Entity boolean값은 원시 타입으로 해두는 것이 좋다고 생각하는데 이유가 있을까요?
There was a problem hiding this comment.
어라,,,? 뭐지 바꾼 기억이 없는데,,,ㅎ 다시 바꿔 놓겠습니다 !
| List<SubTask> findByTaskId(Long taskId); | ||
|
|
||
| default SubTask findByIdOrThrow(Long subTaskId) { | ||
| return findById(subTaskId).orElseThrow( | ||
| () -> new NotFoundException(ErrorCode.NOT_FOUND_SUB_TASK)); |
There was a problem hiding this comment.
p4;
repository마다 목록 조회 method 이름이 findAll과 find로 다른데 통일해도 좋을 것 같습니다!
| } | ||
|
|
||
| @Override | ||
| @Transactional |
There was a problem hiding this comment.
p2;
readOnly = true를 넣어주세요!
| private final CategoryRepository categoryRepository; | ||
|
|
||
| @Override | ||
| @Transactional |
There was a problem hiding this comment.
p2;
readOnly = true를 넣어주세요!
| //* 업무 전체 목록 조회 | ||
| List<TaskGetResponseDto> getAllTask(Long memberId); | ||
|
|
||
| //* 특정 카테고리 내 업무 목록 조회 | ||
| List<TaskGetResponseDto> getByCategoryId(Long categoryId); | ||
|
|
||
| //* 업무 수정 | ||
| void updateTaskName(Long taskId, TaskUpdateRequestDto taskUpdateRequestDto); | ||
|
|
||
| void createTaskName(TaskCreateRequestDto taskCreateRequestDto); | ||
| void deleteTask(Long taskId); |
There was a problem hiding this comment.
p4;
주석은 삭제하거나 통일하는 것이 좋을 것 같습니다!
| @JoinColumn(name = "folder_id") | ||
| private Folder folder; | ||
|
|
||
| @Column(nullable = false) |
There was a problem hiding this comment.
p3;
원시타입이므로 nullable=false가 없어도 괜찮을 것 같아요!
📝 Summary
👩💻 Contents
📝 Review Note
📣 Related Issue
📬 Reference