Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/starknet_getBlockWithTxs #26

Open
antiyro opened this issue Sep 17, 2023 · 4 comments
Open

feat/starknet_getBlockWithTxs #26

antiyro opened this issue Sep 17, 2023 · 4 comments
Assignees
Labels
RPC RPC implementation related issues stale

Comments

@antiyro
Copy link
Member

antiyro commented Sep 17, 2023

Issue: Implement starknet_getBlockWithTxs RPC Call

Description:
Get block information with full transactions given the block id.

Parameters:

  • block_id: The hash of the requested block, or number (height) of the requested block, or a block tag. This parameter is required.

Expected Result:
The resulting block information with full transactions. The result can be:

  1. Block with transactions
  2. Pending block with transactions

Potential Errors:

  • BLOCK_NOT_FOUND: The block requested could not be found.

Testing:
Initial testings can be found here. However, these should not be considered complete and improvements are welcome.

Resources:

Comments:
Please comment below for coordination.

@antiyro antiyro added this to Deoxys Sep 17, 2023
@antiyro antiyro converted this from a draft issue Sep 17, 2023
@antiyro antiyro added the RPC RPC implementation related issues label Sep 17, 2023
@github-actions
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Oct 18, 2023
@jbcaron
Copy link
Member

jbcaron commented Jan 4, 2024

can i take this one

@github-actions github-actions bot removed the stale label Jan 5, 2024
@antiyro antiyro moved this from 🆕 New to 🏗 In progress in Deoxys Jan 5, 2024
@jbcaron
Copy link
Member

jbcaron commented Jan 11, 2024

tests:

  • non existing block
  • existing block
  • latest block
  • pending block

to implement:

  • add l1_gas_price.price_in_wei, first block with eth_l1_gas_price is block 1735

@antiyro antiyro moved this from 🏗 In progress to 👀 In review in Deoxys Jan 22, 2024
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Feb 23, 2024
@antiyro antiyro moved this from 👀 In review to ✅ Done in Deoxys Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RPC RPC implementation related issues stale
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants