Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary dependencies of DE-IVAExtension #9760

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Remove unnecessary dependencies of DE-IVAExtension #9760

merged 1 commit into from
Aug 14, 2023

Conversation

Jules-Bertholet
Copy link
Contributor

@Jules-Bertholet Jules-Bertholet commented Aug 14, 2023

These dependencies are no longer needed, per https://forum.kerbalspaceprogram.com/topic/211932-112x-de_ivaextension-adopted-aset-ivas-for-all-stock-pods/:

  • ToolbarController
  • ClickThroughBlocker

Copy link
Member

@HebaruSan HebaruSan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, these mods are neither mentioned on the current forum thread nor bundled in the ZIP:

image

Thanks for letting us know! FYI to @JonnyOThan.

@HebaruSan HebaruSan merged commit f61e0b0 into KSP-CKAN:master Aug 14, 2023
1 check passed
@Jules-Bertholet Jules-Bertholet deleted the Jules-Bertholet-de-iva-deps branch August 14, 2023 22:11
@JonnyOThan
Copy link
Contributor

JonnyOThan commented Aug 15, 2023

Uh what? ASET props and MM are definitely dependencies. And they’re mentioned in the OP of that thread.

ohhh I didn’t look at the diff. Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants