Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nested ctype #912

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: nested ctype #912

wants to merge 1 commit into from

Conversation

aybarsayan
Copy link

@aybarsayan aybarsayan commented Oct 25, 2024 •
edited
Loading

fixes #3632

Its my first time contributing to a lib package, if I missed anything please let me know.

How to test:

Please provide a brief step-by-step instruction.
If necessary provide information about dependencies (specific configuration, branches, database dumps, etc.)

  • Step 1
  • Step 2
  • etc.

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

@rflechtner
Copy link
Contributor

Is this superseded by the other nested ctype PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rflechtner rflechtner Awaiting requested review from rflechtner

@Dudleyneedham Dudleyneedham Awaiting requested review from Dudleyneedham

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aybarsayan @rflechtner