refactor!: remove message encryption types and tools #793
Conversation
arty-name
force-pushed
the
ta-remove-message-encryption-types-and-tools
branch
from
8c69bbf
to
3d7ed05
Compare
arty-name
force-pushed
the
ta-remove-message-encryption-types-and-tools
branch
from
3d7ed05
to
d7c53aa
Compare
| @@ -5,7 +5,12 @@ | |||
| * found in the LICENSE file in the root directory of this source tree. | |||
| */ | |||
|
|
|||
| import { DidDocument, DidServiceEndpoint, DidUri } from '@kiltprotocol/types' | |||
| import { | |||
There was a problem hiding this comment.
| import { | |
| import type { |
|
|
||
| /** | ||
| * Generate from a seed a x25519 keypair to be used as DID encryption key. | ||
| * | ||
| * @param seed The keypair seed, only optional in the tests. | ||
| * @returns The keypair. | ||
| */ | ||
| export function makeEncryptionKeypairFromSeed( | ||
| seed = randomAsU8a(32) | ||
| ): KiltEncryptionKeypair { | ||
| return { | ||
| ...naclBoxPairFromSecret(seed), | ||
| type: 'x25519', | ||
| } | ||
| } |
There was a problem hiding this comment.
I get removing the encrypt/decrypt stuff, but don't you think we should keep key creation around as we allow a certain set of public key types on DIDs and removing this would mean x25519 keys are the only ones that cannot be created using the sdk?
There was a problem hiding this comment.
This is more of a discussion PR. If these keys are only usable for messaging, and the messaging is deprecated, probably we don’t need to support them by the SDK directly. If you think they’d still be useful, let’s close this :)
There was a problem hiding this comment.
yeah I would rather keep it around for now. x25519-based key agreement is a use case for our DIDs, and even if there are other encryption schemes based on that besides the one implemented here, I think it's fair to have at least one supported by the sdk.
We’ve removed messages but some message-related types and tools remained, this PR cleans it up. I’d argue that they should rather be added in the kilt-extension-api.
Checklist: