Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create new asset-credentials package #787

Merged
merged 11 commits into from
Aug 10, 2023
Merged

Conversation

ntn-x2
Copy link
Member

@ntn-x2 ntn-x2 commented Aug 10, 2023

Fixes https://github.com/KILTprotocol/ticket/issues/2862 by renaming the old asset-did package into asset-credentials, and including the public credentials stuff which used to live in core.

@ntn-x2 ntn-x2 requested a review from rflechtner August 10, 2023 09:08
@ntn-x2 ntn-x2 self-assigned this Aug 10, 2023
@ntn-x2
Copy link
Member Author

ntn-x2 commented Aug 10, 2023

@rflechtner I don't know why the yarn install --immutable fails. I don't get any updates on my Mac... Any idea why?

@rflechtner
Copy link
Contributor

@rflechtner I don't know why the yarn install --immutable fails. I don't get any updates on my Mac... Any idea why?

Also changes on my machine! What node version were you using?

packages/utils/src/Chain.ts Outdated Show resolved Hide resolved
tests/integration/PublicCredentials.spec.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rflechtner rflechtner merged commit 5473696 into develop Aug 10, 2023
11 of 13 checks passed
@rflechtner rflechtner deleted the aa/asset-credentials branch August 10, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants