Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle GitHub redirections? #29

Open
jiahao opened this issue Feb 21, 2015 · 2 comments
Open

Handle GitHub redirections? #29

jiahao opened this issue Feb 21, 2015 · 2 comments

Comments

@jiahao
Copy link
Contributor

jiahao commented Feb 21, 2015

julia> contributors("dlfivefifty", "ApproxFun.jl")

HttpError(404,"Not Found","https://developer.github.com/v3")
while loading In[42], in expression starting on line 103

 in handle_error at /Users/jiahao/.julia/v0.3/GitHub/src/error.jl:36
 in get_pages at /Users/jiahao/.julia/v0.3/GitHub/src/utils.jl:78
 in get_pages at /Users/jiahao/.julia/v0.3/GitHub/src/utils.jl:77
 in contributors at /Users/jiahao/.julia/v0.3/GitHub/src/repos.jl:132
 in contributors at /Users/jiahao/.julia/v0.3/GitHub/src/repos.jl:120

This particular package was moved to https://github.com/ApproxFun/ApproxFun.jl.

@WestleyArgentum
Copy link
Collaborator

Oh, interesting, it shouldn't return a 404 if it wants to redirect... I'll have to poke at this

@WestleyArgentum
Copy link
Collaborator

Just an update, I looked at the data being returned from this call, unfortunately it's just a 404 with ["message"=>"Not Found","documentation_url"=>"https://developer.github.com/v3"]... no nice redirect links or anything.

Not quite sure the best way around this. Possibly we could make a second request to regular github (as opposed to the api) and detect a redirect, but that does introduce overhead and sounds like it could be brittle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants