Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_repo: params should be a keyword argument #219

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Conversation

fredrikekre
Copy link
Member

This patch deprecates params as a positional argument and replace it with a keyword argument (like for all other API functions). I noticed this when the params I passed as keyword argument were overriding the params created with the name positional argument.

This patch deprecates `params` as a positional argument and replace it
with a keyword argument (like for all other API functions). I noticed
this when the `params` I passed as keyword argument were overriding the
`params` created with the `name` positional argument.
@fredrikekre fredrikekre merged commit 3b231b5 into master Oct 14, 2023
9 checks passed
@fredrikekre fredrikekre deleted the fe/create_repo branch October 14, 2023 08:27
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 57.76%. Comparing base (f794531) to head (2ef50d9).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/repositories/repositories.jl 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
- Coverage   58.17%   57.76%   -0.42%     
==========================================
  Files          37       37              
  Lines         899      902       +3     
==========================================
- Hits          523      521       -2     
- Misses        376      381       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant