Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to get commits from a PR #190

Merged
merged 4 commits into from
Nov 24, 2022

Conversation

rick2047
Copy link
Contributor

@rick2047 rick2047 commented Oct 24, 2021

Fixes #116. I am not sure how to test this though.

@rick2047
Copy link
Contributor Author

I would also like to add a method which only takes PR as input. But the API needs both the repo name and PR number and the PR objects do not include the repo name.

@maleadt
Copy link
Collaborator

maleadt commented Nov 24, 2022

Rebased, fixed, and added a test.

I would also like to add a method which only takes PR as input. But the API needs both the repo name and PR number and the PR objects do not include the repo name.

That can be accessed as pr.repo.base. I added a method.

@maleadt maleadt merged commit 35de1cc into JuliaWeb:master Nov 24, 2022
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.23%. Comparing base (9cac3b9) to head (48d810b).
Report is 16 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #190   +/-   ##
=======================================
  Coverage   56.22%   56.23%           
=======================================
  Files          36       36           
  Lines         843      850    +7     
=======================================
+ Hits          474      478    +4     
- Misses        369      372    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get commits from a PR
2 participants