Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for RData to 1, (keep existing compat) #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the RData package from 0.5, 0.6, 0.7, 0.8 to 0.5, 0.6, 0.7, 0.8, 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@andreasnoack andreasnoack reopened this Mar 28, 2023
@asinghvi17 asinghvi17 closed this Jun 5, 2023
@asinghvi17 asinghvi17 reopened this Jun 5, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.66 🎉

Comparison is base (b1a5959) 83.33% compared to head (5f95af2) 84.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   83.33%   84.00%   +0.66%     
==========================================
  Files           3        4       +1     
  Lines          24       25       +1     
==========================================
+ Hits           20       21       +1     
  Misses          4        4              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@asinghvi17 asinghvi17 closed this Apr 2, 2024
@asinghvi17 asinghvi17 reopened this Apr 2, 2024
@asinghvi17
Copy link
Collaborator

asinghvi17 commented Apr 2, 2024

Do we care about Julia 1.0 going forward? If so we can loosen the Formatting.jl restrictions (we should also move to Format.jl btw, which is better maintained). If not, then we can simply remove that CI and upgrade compat with Julia to v1.3 or something, or potentially even v1.6.

Of course, users on Julia 1.0 can still install older versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants